Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more types to parquet reader/writer #2339

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Add more types to parquet reader/writer #2339

merged 1 commit into from
Nov 3, 2023

Conversation

acquamarin
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a4ed60f) 88.81% compared to head (f53ea8d) 88.78%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2339      +/-   ##
==========================================
- Coverage   88.81%   88.78%   -0.03%     
==========================================
  Files        1006     1007       +1     
  Lines       32998    33043      +45     
==========================================
+ Hits        29306    29337      +31     
- Misses       3692     3706      +14
Files Coverage Δ
src/include/common/types/timestamp_t.h 100.00% <ø> (ø)
...rc/include/function/timestamp/timestamp_function.h 100.00% <100.00%> (ø)
...operator/persistent/reader/parquet/column_reader.h 63.63% <ø> (ø)
...rator/persistent/reader/parquet/parquet_reader.cpp 69.58% <100.00%> (+1.36%) ⬆️
...erator/persistent/writer/parquet/column_writer.cpp 90.57% <100.00%> (ø)
...rator/persistent/writer/parquet/parquet_writer.cpp 98.21% <100.00%> (+0.08%) ⬆️
tools/nodejs_api/src_cpp/node_util.cpp 94.07% <100.00%> (ø)
src/common/types/timestamp_t.cpp 84.89% <75.00%> (-0.75%) ⬇️
...erator/persistent/reader/parquet/column_reader.cpp 58.77% <85.71%> (+1.89%) ⬆️
...or/persistent/reader/parquet/parquet_timestamp.cpp 80.00% <80.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit 84f145c into master Nov 3, 2023
12 checks passed
@acquamarin acquamarin deleted the parquet-reader-writer branch November 3, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acquamarin @ray6080